Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactor-rust as a submodule #1291

Closed
lhstrh opened this issue Jul 12, 2022 · 1 comment · Fixed by #1296
Closed

Add reactor-rust as a submodule #1291

lhstrh opened this issue Jul 12, 2022 · 1 comment · Fixed by #1296
Assignees
Labels
rust Related to the Rust target
Milestone

Comments

@lhstrh
Copy link
Member

lhstrh commented Jul 12, 2022

We plan to publish release notes for our runtime implementations as part of the Lingua Franca release notes. This will give the runtime implementations more visibility, and it compensates for a lack of versioning/releases of happening in their repositories. Currently, all our runtime implementations are hooked into the Lingua Franca repository as a submodule, _except for reactor-rust, for which we keep track of its refs in a separate file. To make it easier to automatically generate and include release notes for reactor-rust, we should also include it as a submodule.

Note the command git submodule can be used to find the ref a submodule points to.

Going forward, we should always include a runtime used by LF as a submodule, unless the runtime maintains its own versioning/releases.

If we decide that using a submodule for reactor-rust is not a good fit, we can also resolve this by starting to do proper versioning for it and publish release notes separately.

@cmnrd cmnrd added rust Related to the Rust target labels Jul 13, 2022
@cmnrd
Copy link
Collaborator

cmnrd commented Jul 13, 2022

Just to add a few thoughts: Currently we let cargo resolve reactor-rust. Maybe it would be possible to let cargo default to the version of reactor-rust that is shipped with lfc (as a submodule) and let it only resolve reactor-rust from its git repo if the user explicitly specifies a different runtime version. This would be analogous to the current setup for C++, where we use the builtin version of reactor-cpp by default, but we can also specify another version or use one that is installed to the local system.

@cmnrd cmnrd self-assigned this Jul 13, 2022
@cmnrd cmnrd added this to the 0.3.0 milestone Jul 13, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to the Rust target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants