Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusion of reactor-rs as a submodule #1296

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Inclusion of reactor-rs as a submodule #1296

merged 5 commits into from
Jul 18, 2022

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jul 14, 2022

This PR adds reactor-rs as a submodule and makes sure that the library is copied to src-gen from the classpath. The generated Cargo.toml is adjusted, so that it reads the local version and only pulls from GitHub if another version is explicitly specified by the user.

Closes #1291

@cmnrd cmnrd requested review from jhaye, lhstrh and oowekyala July 14, 2022 12:41
@cmnrd cmnrd added this to the 0.3.0 milestone Jul 14, 2022
lhstrh
lhstrh approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but I think that instead of removing the README.md, we should update it and explain how a runtime other than what's in the submodule can be specified.

@cmnrd
Copy link
Collaborator Author

cmnrd commented Jul 18, 2022 •
edited
Loading

I don't think that the README is the right place for this. We already explain the target properties runtime-version and external-runtime-path in the docs on the website (although they wrongly state that rust does not support runtime-version). For lfc, we already have the help text which explains the options, but we should probably also have a page in the docs dedicated to lfc.

@cmnrd cmnrd mentioned this pull request Jul 18, 2022
Open
@cmnrd cmnrd merged commit c52ae83 into master Jul 18, 2022
@cmnrd cmnrd deleted the rust-submodule branch July 18, 2022 08:30
@lhstrh lhstrh added the refactoring Code quality enhancement label Jul 20, 2022
@lhstrh lhstrh changed the title Include reactor-rs as a submodule Inclusion of reactor-rs as a submodule Jul 20, 2022
@cmnrd cmnrd mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@jhaye jhaye Awaiting requested review from jhaye

@oowekyala oowekyala Awaiting requested review from oowekyala

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Add reactor-rust as a submodule
2 participants
@cmnrd @lhstrh