Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge JavaAstUtils into ASTUtils #1004

Merged
merged 3 commits into from
Mar 6, 2022
Merged

Merge JavaAstUtils into ASTUtils #1004

merged 3 commits into from
Mar 6, 2022

Conversation

housengw
Copy link
Contributor

@housengw housengw commented Mar 5, 2022 •
edited
Loading

@housengw housengw changed the title Merge ast utils Merge JavaAstUtils into ASTUtils Mar 5, 2022
lhstrh
lhstrh reviewed Mar 6, 2022
View reviewed changes
org.lflang/src/org/lflang/TimeUnit.java
@@ -100,7 +100,7 @@ public static TimeUnit fromName(String name) {
*/
public static boolean isValidUnit(String name) {
if (name == null) {
return true;
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

lhstrh
lhstrh approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@lhstrh lhstrh merged commit 787c579 into master Mar 6, 2022
@lhstrh lhstrh deleted the merge-ast-utils branch March 6, 2022 23:39
@lhstrh lhstrh mentioned this pull request Mar 17, 2022
Closed
@lhstrh lhstrh added the refactoring Code quality enhancement label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
refactoring Code quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@housengw @lhstrh