Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout options #1015

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Conversation

soerendomroes
Copy link
Collaborator

This requires #1014 to be merged first.

The layout option setLayoutOption(node, LayeredOptions.THOROUGHNESS, 100); is debatable since it may increase the time needed for automatic layout. However, it seems to be quick enough for all examples I tested and is still in millisecond range.

Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is mixed up with changes from #1014.

Do these layout changes require the upcoming elk release or are they compatible with the currently used release?

@soerendomroes
Copy link
Collaborator Author

This PR is mixed up with changes from #1014.

Do these layout changes require the upcoming elk release or are they compatible with the currently used release?

They work with the current release.

@lhstrh lhstrh merged commit 99d4a64 into lf-lang:master Mar 10, 2022
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Mar 17, 2022
@a-sr
Copy link
Collaborator

a-sr commented Mar 30, 2022

@soerendomroes I just noticed that your changes to the SEPARATE_CONNECTED_COMPONENTS have a negative effect on the aesthetics of certain models.

SCC on:
cutter-scc-on

SCC off:
cutter-scc-off
Here the startup reaction chain is unpleasantly stretched out through the layers of the other reactors.

Could you comment on is. Is there a way to we can have separate but ordered connected components?

@soerendomroes
Copy link
Collaborator Author

Yes, there is an easy way to do this but it is not implemented in ELK. I will try to include it in the upcoming 0.8.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants