Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for interleaved operator to Rust target #1133

Merged
merged 5 commits into from
May 3, 2022
Merged

Conversation

jhaye
Copy link
Collaborator

@jhaye jhaye commented May 2, 2022

This adds support for the interleaved operator to the Rust target, including a unit test.

The test passes but has to be compiled with threading disabled, otherwise the output gets garbled.

@jhaye jhaye added the rust Related to the Rust target label May 2, 2022
@jhaye jhaye requested a review from cmnrd May 2, 2022 15:22
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cmnrd cmnrd merged commit a60e659 into master May 3, 2022
@cmnrd cmnrd deleted the rust-interleaved branch May 3, 2022 08:11
@cmnrd
Copy link
Collaborator

cmnrd commented May 3, 2022

Regarding the garbled output: We should introduce a thread-safe logging API for Rust (see #1138).

@petervdonovan petervdonovan added the enhancement Enhancement of existing feature label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature rust Related to the Rust target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants