Check for Java 17 in lfc scripts and properly exit on error #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
requested changes
May 3, 2022
petervdonovan
approved these changes
May 3, 2022
There was a problem hiding this comment.
I can confirm that this works on Windows, correctly producing the following error:
JRE 11.0.12.0 found but 17.0 or greater is required.
At C:\lingua-franca\bin\lfc.ps1:46 char:5
+ throw "JRE $java_version found but 17.0 or greater is required."
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : OperationStopped: (JRE 11.0.12.0 f...er is required.:String) [], RuntimeException
+ FullyQualifiedErrorId : JRE 11.0.12.0 found but 17.0 or greater is required.
|
Excellent. Thank you for checking, @petervdonovan! |
lhstrh
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the build and launch lfc scripts to check for a Java 17 runtime (instead of 11). Also it introduces a small fix that let's the script exit gracefully if no Java 17 runtime was found.