Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted build to fall back to python command if python3 is not available #1197

Merged
merged 2 commits into from
May 28, 2022
Merged

Adjusted build to fall back to python command if python3 is not available #1197

merged 2 commits into from
May 28, 2022

Conversation

Soroosh129
Copy link
Contributor

This PR adds a fallback mechanism for platforms that do not have the python3 command but do have a python command that points to a Python 3 interpreter.

@Soroosh129 Soroosh129 requested a review from lhstrh May 27, 2022 17:43
edwardalee
edwardalee approved these changes May 28, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Soroosh129 Soroosh129 merged commit ada749f into master May 28, 2022
@Soroosh129 Soroosh129 deleted the python-build-update branch May 28, 2022 16:29
@lhstrh lhstrh changed the title [Python] Adjusted build to fall back to python [Python] Adjusted build to fall back to python command if python3 is not available May 31, 2022
@lhstrh lhstrh added python Related to the Python target enhancement Enhancement of existing feature labels May 31, 2022
@lhstrh lhstrh changed the title [Python] Adjusted build to fall back to python command if python3 is not available Adjusted build to fall back to python command if python3 is not available May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature python Related to the Python target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soroosh129 @edwardalee @lhstrh