Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c] A deadline of 0 is no longer interpreted as an _absent_ deadline but one that can never be met #1217

Merged
merged 5 commits into from
Jun 11, 2022

Conversation

billy-bao
Copy link
Collaborator

If no deadline is specified in the LF program, the C code generator will set the deadline field of the reaction to NEVER (a negative value), which is interpreted as no deadline in the runtime. This fixes issue #1203 along with an update to the C runtime (lf-lang/reactor-c#86).

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported failure appears to be due to recent changes in master that got merged in here (not your change), so let's go ahead and merge this.

@lhstrh lhstrh merged commit bbc3d85 into master Jun 11, 2022
@lhstrh lhstrh deleted the c-deadline-zero branch June 11, 2022 19:48
@lhstrh lhstrh added the bug Something isn't working label Jul 7, 2022
@lhstrh lhstrh changed the title Generate code to set negative deadline if there is no deadline specified [c] A deadline of 0 is no longer interpreted as an _absent_ deadline but one that can never be met Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants