Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustment of code generator to address #1368 #1370

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Adjustment of code generator to address #1368 #1370

merged 4 commits into from
Sep 17, 2022

Conversation

lsk567
Copy link
Collaborator

@lsk567 lsk567 commented Sep 16, 2022 •
edited by lhstrh
Loading

Fixes #1368.

@lsk567 lsk567 linked an issue Sep 16, 2022 that may be closed by this pull request
Memory error with reactions writing to multiple ports #1368
Closed
@lhstrh lhstrh added the bugfix label Sep 16, 2022
@lhstrh lhstrh changed the title Fix the code generator and add a test for #1368. Adjustment of code generator to address #1368 Sep 16, 2022
lhstrh
lhstrh approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for tracking this down! You might want to run the formatter on the test to make sure it is formatted correctly and avoid a test failure.

test/C/src/MultipleOutputs.lf Outdated Show resolved Hide resolved
lsk567 and others added 2 commits September 16, 2022 16:18
@lsk567 @lhstrh
Update test/C/src/MultipleOutputs.lf
8628456 
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
@lhstrh
Applied formatter
0517021
@lhstrh
Copy link
Member

lhstrh commented Sep 16, 2022

Note: I ran ./gradlew runLff --args "test/C/src/MultipleOutputs.lf"

edwardalee
edwardalee approved these changes Sep 17, 2022
View reviewed changes
Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! To be a test, the MultiportOutputs.lf needs to call lf_print_error_and_exit if the reaction to to c.z is not invoked. That can be handled in a shutdown reaction that checks a state variable.

@lhstrh lhstrh merged commit d39729c into master Sep 17, 2022
@lhstrh lhstrh deleted the 1368-memory-error-with-reactions-writing-to-multiple-ports branch September 17, 2022 02:54
@petervdonovan petervdonovan mentioned this pull request Sep 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory error with reactions writing to multiple ports
3 participants
@lsk567 @lhstrh @edwardalee