Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented support for Arduino #1384

Merged
merged 15 commits into from
Oct 8, 2022
Merged

Augmented support for Arduino #1384

merged 15 commits into from
Oct 8, 2022

Conversation

arengarajan99
Copy link
Contributor

@arengarajan99 arengarajan99 commented Sep 29, 2022

This PR will address the following issues dealing with running Arduino on LF

  • Autogeneration of custom Board Options file via tweaking of Platform parameter to support overloaded definitions (Complete)
  • Copy over of Arduino-Toolchain files to allow self-sufficient compilation of LF-Arduino programs without reliance on building LF from source (should support Nightly Build and release versions) (Complete)
  • Support of external Arduino-supported libraries (Complete)

@arengarajan99 arengarajan99 added this to the 0.4.0 milestone Oct 4, 2022
@arengarajan99 arengarajan99 added the enhancement Enhancement of existing feature label Oct 4, 2022
@erlingrj
Copy link
Collaborator

erlingrj commented Oct 4, 2022

@lhstrh Anirudh would like to finish this line of work before applying the changes related to 64bit and nanoseconds to the Arduino port. I think this is reasonable, but I also think it is possible to apply the other changes first. I am mentioning this because there have very recently been discussions on what is really the job of LFC and how should we extend support to multiple embedded targets. This PR sort of represents one possible path where we tightly integrate support for embedded targets into LFC and try to have "end-to-end" build and flash through LFC.

I do think that we can merge this in even before making a decision on how to support embedded targets. In the worst case we would have to do refactoring later. I am pushing a bit on this because it should be done before we can merge lock_time branch into reactor-c main so that we can start working on supporting more embedded targets

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I am afraid that the approach of hard coding all platforms in an enum will require too much maintenance, but I'm not sure we have a viable alternative. These are certainly improvements over what's currently in master, so let's merge.

@lhstrh lhstrh changed the title Augmented Support for Arduino on LF Augmented Support for Arduino Oct 8, 2022
@lhstrh lhstrh merged commit dc76c75 into master Oct 8, 2022
@lhstrh lhstrh deleted the arduino-support branch October 8, 2022 00:23
@petervdonovan petervdonovan changed the title Augmented Support for Arduino Augmented support for Arduino Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants