Better multiport support for Rust #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oowekyala
force-pushed
the
rust.support-better-multiports
branch
from
f1358c4
to
2d9d77a
Compare
oowekyala
force-pushed
the
rust.support-better-multiports
branch
from
2d9d77a
to
9b21c94
Compare
oowekyala
force-pushed
the
rust.support-better-multiports
branch
from
73fdd6d
to
c6ea5be
Compare
|
Is this ready for review? From the rust benchmark test failure I assume this also needs to be accompanied by changes in the benchmark repo, right? |
|
Thanks for the pointer, I had forgotten about that. I'll open a PR there. I think the changes are stable now so I will mark this as ready for review |
|
Seems like this slightly changes the API for |
oowekyala
added a commit
to lf-lang/benchmarks-lingua-franca
that referenced
this pull request
Nov 14, 2022
oowekyala
force-pushed
the
rust.support-better-multiports
branch
from
6217b25
to
a4bb59e
Compare
oowekyala
force-pushed
the
rust.support-better-multiports
branch
from
cd76a4c
to
d82f816
Compare
oowekyala
added a commit
to lf-lang/benchmarks-lingua-franca
that referenced
this pull request
Nov 16, 2022
Everything is already a reference
cmnrd
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion branch to lf-lang/reactor-rs#29.