Fix for passing of command line options from lfc to the generator #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all command line options that need to be passed on from lfc to the code generator do not work. This change provides a fix. Concretely, it replaces the automagic passing in a for loop from before with explicit code for each individual option. While it is a bit more verbose, this has some advantages: - The code is readable and understandable - IntelliJ produces a useful warning when an option is not used and therefore not passed on This change further removes some unused code and includes other small cleanups. All in all, this removes all warnings shown bu IntelliJ.
patilatharva
approved these changes
Mar 9, 2023
lhstrh
approved these changes
Mar 10, 2023
|
This bugfix warrants a patch release... |
|
Did we merge the picocli PR before the release? I think it wasn't in there. It also does not show in the release notes. |
|
Oh, right, we didn't.
…On Thu, Mar 9, 2023 at 11:44 PM Christian Menard ***@***.***> wrote:
Did we merge the picocli PR before the release? I think it wasn't in
there. It also does not show in the release notes.
—
Reply to this email directly, view it on GitHub
<#1631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYD47EJJ2ECNRSA4CO7IFDW3LLV5ANCNFSM6AAAAAAVVDZ4MY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
petervdonovan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all command line options that need to be passed on from lfc to the code generator do not work. The reason for this, is that the long option names (e.g.
--clean) are compared with the property names (e.g.clean). This change provides a fix. Concretely, it replaces the automagic passing in a for loop from before with explicit code for each individual option. While it is a bit more verbose, this has some advantages:This change further removes some unused code and includes other small cleanups. All in all, this removes all warnings shown by IntelliJ.