Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for C++ tests #1979

Merged
merged 1 commit into from Sep 8, 2023
Merged

Minor fixes for C++ tests #1979

merged 1 commit into from Sep 8, 2023

Conversation

tanneberger
Copy link
Collaborator

Things Done

  • replaced int in for loop and replaced it with auto

@lhstrh lhstrh requested a review from cmnrd August 31, 2023 17:03
@lhstrh lhstrh changed the title Fixing CPP Unit Tests Minor fixes for C++ tests Sep 7, 2023
@lhstrh lhstrh added the testing label Sep 7, 2023
@cmnrd
Copy link
Collaborator

cmnrd commented Sep 8, 2023

What is the motivation for this change? Just to get rid of warnings, or is there something additional?

@tanneberger
Copy link
Collaborator Author

Just the warnings

Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cmnrd cmnrd added this pull request to the merge queue Sep 8, 2023
Merged via the queue into master with commit a07974d Sep 8, 2023
41 checks passed
@cmnrd cmnrd deleted the fixing-cpp-unit-tests branch September 8, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants