Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CMake generator for pico platform #2303

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fixed CMake generator for pico platform #2303

merged 1 commit into from
Jun 3, 2024

Conversation

edwardalee
Copy link
Collaborator

This PR fixes the CMake generator so that the RP2040 platform works with the new layout of reactor-c. To be able to build RP2040 code, we also need the companion PR.

Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to configure the std lib that reactor-c links to in the generated CmakeLists.txt? Shouldn't this be part of the platform support in reactor-c?

@lhstrh lhstrh added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit 8d9e7bd Jun 3, 2024
26 checks passed
@lhstrh lhstrh deleted the rp2040-fixes branch June 3, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants