Fixed NRF52 support #2305
Merged
Fixed NRF52 support #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM, but I should you'll want to first merge lf-lang/reactor-c#441 and then overwrite fa876d3 and point to main. You can do this simply with git reset HEAD~ (rewind the commit log by one); pointing the submodule to the right ref, and doing git push -f.
lhstrh
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the refactoring of platform support, code generation for NRF52 stopped working. This is a first step towards getting it working again.
Currently, NRF52 examples do not compile for failing to find "nrf.h". I could use some help figuring out how to properly handle integrating the NRF52 SDK into our CMake build system.
This PR depends on branch rp2040-fixes which should be merged first. See PR #2303.