Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle setup by setting kotlin version to 1.4.30 #934

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Feb 3, 2022

According to the gradle documentation, gradle 7.0 supports kotlin 1.4.30. Specifying this kotlin version in gradle.properties fixes the build problems described in #930.

Closes #930

According to the
[gradledocumentation](https://docs.gradle.org/current/userguide/upgrading_version_6.html),
gradle 7.0 supports kotlin 1.4.30. Specifying this kotlin version in
gradle.properties fixes the build problems described in #930.

Closes #930
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmnrd! As far as I know the motivation for the Kotlin version bump had been that the default JVM target was too old, but since we set the JVM target to 11, this looks like it should be no problem.

@lhstrh lhstrh merged commit 52e088b into master Feb 3, 2022
@oowekyala oowekyala deleted the gradle-fix branch February 5, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin classes do not get build by buildLfc task (unless the clean task is also run)
3 participants