Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent way of handling entry and exit of critical section #136

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Consistent way of handling entry and exit of critical section #136

merged 3 commits into from
Jan 8, 2023

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Jan 6, 2023 •
edited by lhstrh

Fixes #135.

@erlingrj
Copy link
Collaborator Author

erlingrj commented Jan 6, 2023

For some reason, the CI will not run. Also not on my Zephyr branch. Will look at it later

@lhstrh lhstrh requested a review from edwardalee January 7, 2023 18:26
edwardalee
edwardalee approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@erlingrj erlingrj merged commit 9fb0627 into main Jan 8, 2023
@lhstrh lhstrh changed the title Make enter/exit critical section consistent Consistent way of handling entry and exit of critical section Jan 26, 2023
@lhstrh lhstrh added the bugfix label Jan 26, 2023
@erlingrj erlingrj deleted the critical-sections branch February 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return value of lf_critical_section_enter() and exit() are inconsistent
3 participants
@erlingrj @edwardalee @lhstrh