Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of unnecessary TAG messages #175

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Removal of unnecessary TAG messages #175

merged 5 commits into from
Mar 8, 2023

Conversation

byeonggiljun
Copy link
Collaborator

@byeonggiljun byeonggiljun commented Mar 7, 2023 •
edited by lhstrh

This PR is for optimizing message exchanges in centralized federated execution.

For more information, please look at lingua-franca/discussions/1626.

edwardalee
edwardalee requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the two questions I raised, this looks good to me. Let's make sure all the tests pass.

core/federated/RTI/rti_lib.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.c Outdated Show resolved Hide resolved
@byeonggiljun byeonggiljun changed the title Draft: Generalizing and Optimizing Centralized Federated Execution Do not send TAG message when a federate do not have to advance its tag Mar 8, 2023
edwardalee
edwardalee approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@byeonggiljun byeonggiljun marked this pull request as ready for review March 8, 2023 08:12
@byeonggiljun byeonggiljun merged commit 909c3fd into main Mar 8, 2023
@byeonggiljun byeonggiljun deleted the rti-optimizations branch March 8, 2023 08:13
@lhstrh lhstrh changed the title Do not send TAG message when a federate do not have to advance its tag Removal of unnecessary TAG messages Aug 28, 2023
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

@lhstrh lhstrh Awaiting requested review from lhstrh

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@byeonggiljun @edwardalee @lhstrh