Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Arduino to avoid duplicate definition of timespec #195

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix for Arduino to avoid duplicate definition of timespec #195

merged 1 commit into from
May 15, 2023

Conversation

arengarajan99
Copy link
Collaborator

No description provided.

@lhstrh lhstrh changed the title Add fix to Arduino Timespec to account for different timespec header … Fix for Arduino to account avoid duplicate definition of timespec May 15, 2023
@lhstrh lhstrh requested a review from petervdonovan May 15, 2023 06:22
petervdonovan
petervdonovan approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is harmless, but I don't understand why it is necessary. This entire file already has an include guard. Is there another file that also defines timespec?

@lhstrh
Copy link
Member

lhstrh commented May 15, 2023

AFAIK, there is one in the Arduino library that is used with some platforms.

@petervdonovan petervdonovan merged commit 6ff46d0 into main May 15, 2023
25 checks passed
@petervdonovan petervdonovan deleted the arduino-fix branch May 15, 2023 20:39
@lhstrh lhstrh changed the title Fix for Arduino to account avoid duplicate definition of timespec Fix for Arduino to avoid duplicate definition of timespec Aug 28, 2023
@lhstrh lhstrh added the bugfix label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

@lsk567 lsk567 Awaiting requested review from lsk567

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arengarajan99 @lhstrh @petervdonovan