Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory reporting #201

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Memory reporting #201

merged 2 commits into from
Apr 27, 2023

Conversation

edwardalee
Copy link
Contributor

This simple PR moves the check for memory leaks in token to after where template tokens are freed. When token types were made persistent, we started getting warnings about unfreed tokens. But these warnings are spurious. This PR eliminates those warnings.

@edwardalee edwardalee requested a review from lhstrh April 26, 2023 08:30
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, but the scope of this PR is larger than the name suggests.

@edwardalee
Copy link
Contributor Author

These changes look good to me, but the scope of this PR is larger than the name suggests.

Rats. This PR seems to have accidentally included changes in the file-access branch. I guess that PR needs to be merged first.

@edwardalee edwardalee merged commit 75ddd1d into main Apr 27, 2023
11 of 25 checks passed
@edwardalee edwardalee deleted the memory-reporting branch April 27, 2023 04:48
@lhstrh lhstrh added the feature New feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants