Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LF_PACKAGE_DIRECTORY #204

Merged
merged 2 commits into from
Apr 29, 2023
Merged

Added LF_PACKAGE_DIRECTORY #204

merged 2 commits into from
Apr 29, 2023

Conversation

edwardalee
Copy link
Contributor

Companion to PR in lingua-franca.

@edwardalee edwardalee requested a review from lhstrh April 28, 2023 07:36
@lhstrh
Copy link
Member

lhstrh commented Apr 28, 2023

I think we should call this LF_PACKAGE_DIRECTORY instead. To me, the definition of "project" is muddy currently, but the notion of "package" is clear.

@edwardalee
Copy link
Contributor Author

I think we should call this LF_PACKAGE_DIRECTORY instead. To me, the definition of "project" is muddy currently, but the notion of "package" is clear.

I guess if it's clear to you, it's worth changing, so I've done that. To me, both terms are equally mysterious.

@lhstrh lhstrh changed the title Added LF_PROJECT_DIRECTORY Added LF_PACKAGE_DIRECTORY Apr 29, 2023
@lhstrh lhstrh enabled auto-merge April 29, 2023 21:04
@lhstrh lhstrh merged commit 3da0d27 into main Apr 29, 2023
25 checks passed
@lhstrh lhstrh added the feature New feature label Aug 28, 2023
@lhstrh lhstrh deleted the file-access2 branch February 1, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwardalee @lhstrh