Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform abstraction layer for the RTI #213

Merged
merged 3 commits into from
May 18, 2023

Conversation

siljesu
Copy link
Contributor

@siljesu siljesu commented May 18, 2023

In order to port the RTI to different platforms in the future, it should use the platform abstractions already available. This requires changing all pthread functions and types to their corresponding functions and types in platform.h. Additionally, the rti_mutex and two condition variables must be defined outside of the RTI_instance_t, since they no longer can be initialized with PTHREAD_(...)_INITIALIZER macros.

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Let's merge this. Small suggests for comments...

core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
Co-authored-by: Edward A. Lee <eal@eecs.berkeley.edu>
@edwardalee edwardalee merged commit 60d95c1 into lf-lang:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants