Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression of "no symbols" warnings emitted by ranlib #214

Merged
merged 1 commit into from
May 18, 2023

Conversation

petervdonovan
Copy link
Contributor

@petervdonovan petervdonovan commented May 18, 2023

This addresses warnings reported on Mac such as:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libcore.a(scheduler_adaptive.c.o) has no symbols

These warnings are expected because we use the preprocessor to exclude the contents of files that relate to features that are not used.

I have checked that this change suppresses the warnings on the 2013 Mac that we have been using.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@petervdonovan petervdonovan merged commit 843e147 into main May 18, 2023
20 of 25 checks passed
@petervdonovan petervdonovan deleted the suppress-no-symbols-warnings branch May 18, 2023 22:00
@lhstrh lhstrh added the bugfix label Aug 28, 2023
@lhstrh lhstrh changed the title Suppress "no symbols" warnings emitted by ranlib Suppression of "no symbols" warnings emitted by ranlib Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants