Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If clock sync is on, link math #252

Merged
merged 1 commit into from
Jul 21, 2023
Merged

If clock sync is on, link math #252

merged 1 commit into from
Jul 21, 2023

Conversation

petervdonovan
Copy link
Contributor

@petervdonovan petervdonovan commented Jul 21, 2023 •
edited

This fixes compilation errors observed on Ubuntu when the following target properties are used in a federated program:

  clock-sync: on,
  clock-sync-options: {
    local-federates-on: true,
  },

@lhstrh lhstrh mentioned this pull request Jul 21, 2023
Merged
18 tasks
lhstrh
lhstrh approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix!

@lhstrh lhstrh merged commit aaeadfa into main Jul 21, 2023
25 checks passed
@lhstrh lhstrh deleted the link-math-for-clock-sync branch July 21, 2023 05:00
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petervdonovan @lhstrh