-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rp2040 Target Support #253
Conversation
merge in main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, but the functions defined need comments. E.g., _lf_clock_now should state that it return the time since boot in nanoseconds. Note that by convention, comments consist of full sentences with proper punctuation and javadoc style annotations. So, for _lf_clock_now, it should be:
/**
* Write the time since boot in nanoseconds into the variable pointed to by the argument and return 0.
* @param t Pointer to the variable to write to.
*/
Note the use of the imperative case above. I.e., don't say this:
- Writes the time since boot in nanoseconds into the variable pointed to by the argument and return 0.
The above is not a sentence in English.
Looks like all requested changes have been implemented.
Basic unthreaded runtime support for rp2040 target.
Uses the pico-sdk as a dependency and utilizes the high level time library to provide timer support.