Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rp2040 Target Support #253

Merged
merged 26 commits into from
Jul 26, 2023
Merged

Rp2040 Target Support #253

merged 26 commits into from
Jul 26, 2023

Conversation

gundralaa
Copy link
Collaborator

@gundralaa gundralaa commented Jul 21, 2023

Basic unthreaded runtime support for rp2040 target.
Uses the pico-sdk as a dependency and utilizes the high level time library to provide timer support.

  • changed semaphore util to lf_semaphore due to name collisions
  • added lf_rp2040_support files
  • modified platform cmake

core/platform/lf_rp2040_support.c Outdated Show resolved Hide resolved
core/platform/lf_rp2040_support.c Outdated Show resolved Hide resolved
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but the functions defined need comments. E.g., _lf_clock_now should state that it return the time since boot in nanoseconds. Note that by convention, comments consist of full sentences with proper punctuation and javadoc style annotations. So, for _lf_clock_now, it should be:

/**
 * Write the time since boot in nanoseconds into the variable pointed to by the argument and return 0.
 * @param t Pointer to the variable to write to.
 */

Note the use of the imperative case above. I.e., don't say this:

  • Writes the time since boot in nanoseconds into the variable pointed to by the argument and return 0.

The above is not a sentence in English.

core/CMakeLists.txt Outdated Show resolved Hide resolved
core/platform/lf_rp2040_support.c Outdated Show resolved Hide resolved
@lhstrh lhstrh enabled auto-merge July 25, 2023 21:50
@lhstrh lhstrh dismissed edwardalee’s stale review July 26, 2023 02:29

Looks like all requested changes have been implemented.

@lhstrh lhstrh merged commit 586a98f into main Jul 26, 2023
25 checks passed
@lhstrh lhstrh added the feature New feature label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants