-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup pass removing deprecated reactor-body APIs #353
Conversation
This PR is ready for review. There is a companion PR in lingua-franca that requires a further companion review in the benchmarks repo in order to get all tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just some tiny comments
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Since these are breaking changes, this suggests that the next version will be |
This PR removes old, deprecated API macros originally used in early versions of the C runtime in reaction bodies. This enables substantial code simplification and clarification. Specifically, the following macros are removed:
This PR also fixes a bug (see #352). A companion PR in lingua-franca updates tests that had been using the deprecated API.
Some API functions have also been removed:
get_current_tag
(uself_tag
)get_elapsed_physical_time
(uself_time_physical_elapsed
)error_print_and_exit
(uself_print_error_and_exit
)