Fix race condtions related to the scheduling of physical actions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it could happen that a physical action already determines its next tag, but then the scheduler already advances beyond this tag before the new event is inserted in the event queue. In other words, determining the tag and inserting the event at this tag was not an atomic operation. This change includes the determining of the tag in `schedule_async` while the lock is held and hence makes scheduling physical actions an atomic operation.
cmnrd
changed the title
cmnrd
force-pushed
the
physical-actions
branch
from
e52bb65
to
0020790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes to race conditions
schedule_asyncwhile the lock is held and hence makes scheduling physical actions an atomic operation.events_) between scheduling the physical action and setting it up from the scheduler. This was fixed by acquiring the mutex also insetup().