[Forwardport] Variable as a method parameter might be overridden by the loop #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…magento#14470 (fix grid class and test)
[TSG] Upporting for 2.3 (pr25) (2.3.0)
- Skip MC-191 for now so as to not delay weekly PR
- fix MFTF to clear filters before search
… to inputted data on Checkout flow for Logged in Customer - Includes: MC-255, MC-258, MC-259, MC-295, MC-296, MC-297, MC-298
…tom-route-for-bulk-api
…' into bulk-custom-route
…e, Small and Thumbnail from Simple Product - Make image size selectors more robust and not dependent on nth index
- Removed TODO's
Bulk custom route
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#16459: [Forwardport] Add missing showInStore attributes (by @aschrammel) - magento#16521: [Forwardport : Changed password placeholder text in checkout page] (by @hitesh-wagento) - magento#16515: Declare module namespace before template path name (by @mageprince) - magento#16492: Remove the timezone from the date when retrieving the current month from a UTC timestamp. (by @michaelwylde) - magento#15624: [2.3] [improvement] Swatches LESS rewrite (by @Karlasa) Fixed GitHub Issues: - magento#16378: Wrong placeholder for password field in the checkout page (reported by @mohitka) has been fixed in magento#16521 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 386438d - magento#15940: Wrong end of month at Reports for Europe/Berlin time zone if month contains 31 day (reported by @Stepa4man) has been fixed in magento#16492 by @michaelwylde in 2.3-develop branch Related commits: 1. 2482579
…velop Move MFTF tests from dev/tests/acceptance to app/code
… not clear generated code
…n flag should… magento#16573 - Merge Pull Request magento#16573 from gelanivishal/magento2:2.3-develop-PR-port-16211 - Merged commits: 1. 5415aa1
Fixed issues: - MC-2338 3rd party library/dependency upgrade for 2.3 pre Alpha
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#16573: Setting deploy mode to production with --skip-compilation flag should� (by @gelanivishal) - magento#16546: Properly hyphenate "third-party" (by @ronak2ram) - magento#16537: Issue in adding the wishlist of "zero price" product (by @gelanivishal) - magento#16520: [Forwardport] fix: change "My Dashboard" to "My Account", fixes magento#16007 (by @DanielRuf) - magento#16504: [Forwardport] Admin controller product set save refactor (by @AnshuMishra17) - magento#16228: [Forwardport] magento#16079 translation possibility for moreButtonText (by @Karlasa) - magento#13501: [Improvement] Implement customer group grid on ui component (by @simpleadm) Fixed GitHub Issues: - magento#16479: Issue in adding the wishlist of "zero price" product. (reported by @Sathishkumar8731) has been fixed in magento#16537 by @gelanivishal in 2.3-develop branch Related commits: 1. 4cb997a - magento#16079: Need information about translating issue (Magento Swatches Js) (reported by @mageho) has been fixed in magento#16228 by @Karlasa in 2.3-develop branch Related commits: 1. abcded5 2. 988ef89
lfluvisotto
pushed a commit
that referenced
this pull request
Jul 9, 2018
[Forwardport] Correct sentence in comment section in class file.
lfluvisotto
pushed a commit
that referenced
this pull request
Dec 16, 2018
magento 2.3-develop:update branch
lfluvisotto
pushed a commit
that referenced
this pull request
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16143
Description
Variable as a method parameter might be overridden by the loop.
Rename the variable in the loop let the code more readable.