Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Added types of tests and list of essential tests #22

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[DOC] Added types of tests and list of essential tests #22

merged 1 commit into from
Jul 6, 2022

Conversation

agentpoyo
Copy link
Collaborator

This updates the CNFCertification-1.0-beta.md with the types of tests and the list of essentials that provide links to the test within the document.

Ref #: https://github.com/cncf/cnf-certification/issues/21

Signed-off-by: agentpoyo drew.bentley@gmail.com

@agentpoyo
Added types of tests and list of essential tests
fc858a9 
Signed-off-by: agentpoyo <drew.bentley@gmail.com>
@agentpoyo agentpoyo requested review from taylor and lixuna June 27, 2022 19:48
@agentpoyo agentpoyo added documentation Improvements or additions to documentation cnf-certification labels Jun 27, 2022
taylor
taylor approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@taylor taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

in a new ticket it would be good to add the type under each one of the tests. Example

Increase decrease capacity:

  • Type: Essential
  • Added to CNF Certification in v1.0
  • Expectation: The number of replicas for a Pod increases, then the number of replicas for a Pod decreases

@taylor
Copy link
Member

taylor commented Jul 6, 2022

@agentpoyo https://github.com/cncf/cnf-certification/pull/22#pullrequestreview-1030701701

@taylor taylor merged commit 052b313 into lfn-cnti:main Jul 6, 2022
@lixuna lixuna mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor taylor taylor approved these changes

@lixuna lixuna Awaiting requested review from lixuna

Assignees
No one assigned
Labels
cnf-certification documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agentpoyo @taylor