Added several tests for SciPy #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshitaKalani
force-pushed
the
sprint_1
branch
2 times, most recently
from
b26a1c1
to
44d6c12
Compare
Pranavchiku
added
the
SciPy
Pranavchiku
reviewed
Aug 13, 2023
Pranavchiku
reviewed
Aug 13, 2023
Pranavchiku
reviewed
Aug 13, 2023
Pranavchiku
reviewed
Aug 13, 2023
|
Converting this PR to draft. |
HarshitaKalani
force-pushed
the
sprint_1
branch
from
05b554b
to
f1a61dc
Compare
Pranavchiku
reviewed
Aug 16, 2023
Pranavchiku
approved these changes
Aug 16, 2023
HarshitaKalani
force-pushed
the
sprint_1
branch
from
f1a61dc
to
51a863b
Compare
HarshitaKalani
force-pushed
the
sprint_1
branch
2 times, most recently
from
9eced0c
to
5882457
Compare
certik
reviewed
Oct 26, 2023
HarshitaKalani
force-pushed
the
sprint_1
branch
from
4d18a4c
to
73bf62c
Compare
|
This makes it work on macOS: --- a/integration_tests/min_three_args.f90
+++ b/integration_tests/min_three_args.f90
@@ -3,10 +3,11 @@ module min_three_args
contains
subroutine take_min(arr)
real(8), intent(out) :: arr(:,:)
- real(8) :: tmp1, tmp2
+ real(8) :: tmp1, tmp2, tmp3
tmp1 = huge(1.d0)
tmp2 = huge(1.d0)
- arr(:,1) = min( 0.d0,tmp1,tmp2 )
+ tmp3 = min( 0.d0,tmp1,tmp2 )
+ arr(:,1) = tmp3
if (arr(1, 1) /= 0.d0) error stop
if (size(arr) /= 2) error stopThis is an unrelated bug in assigning min to an array, that we need to fix: #2735. |
HarshitaKalani
force-pushed
the
sprint_1
branch
from
73bf62c
to
cc5fcd5
Compare
czgdp1807
approved these changes
Nov 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1795
Fixes: #162
Fixes: #1090
Fixes: #1688
Works already with latest main -
fixed: #1530
fixed: #370
Fixes: #2177