Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix node version compare #2270

Merged
merged 1 commit into from
Aug 29, 2023
Merged

CMake: Fix node version compare #2270

merged 1 commit into from
Aug 29, 2023

Conversation

Shaikh-Ubaid
Copy link
Member

From #597,

CI: Testing NodeJS version compare fix/make-robust
The statement string(COMPARE GREATER_EQUAL "${WASM_EXEC_VERSION}" "v16.0.0" IS_NODE_ABOVE_16) in integration_tests/CMakeLists.txt can/might return wrong/undesired result when the node version is between (around) v2.0.0 to <= v9.x.x

This PR fixes the above.

@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Aug 29, 2023
Merged
@Shaikh-Ubaid Shaikh-Ubaid merged commit 110e63b into lfortran:main Aug 29, 2023
18 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the fix_node_compare branch August 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaikh-Ubaid @certik