Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pass options inside compiler options #2739

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Move pass options inside compiler options #2739

merged 3 commits into from
Oct 27, 2023

Conversation

Shaikh-Ubaid
Copy link
Member

fixes #2738

@Shaikh-Ubaid Shaikh-Ubaid force-pushed the move_pass_options_inside_compiler_options branch from 6cee008 to 164f2ad Compare October 27, 2023 10:54
@Shaikh-Ubaid Shaikh-Ubaid force-pushed the move_pass_options_inside_compiler_options branch from 164f2ad to 2402531 Compare October 27, 2023 11:30
@certik certik requested a review from czgdp1807 October 27, 2023 12:07
czgdp1807
czgdp1807 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral on this.

certik
certik approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral as well. It seems to reduce code (+130 / -243), so let's do it. Thanks!

@certik certik merged commit 08f2c1f into lfortran:main Oct 27, 2023
20 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the move_pass_options_inside_compiler_options branch October 27, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the pass_options object inside the compiler_options object as a data member.
3 participants
@Shaikh-Ubaid @certik @czgdp1807