Support for OverloadedStringConcat and bug fixes #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Jan 2, 2024
| @@ -883,6 +917,7 @@ RUN(NAME string_26 LABELS gfortran llvm fortran) | |||
| RUN(NAME string_27 LABELS gfortran llvm) | |||
| RUN(NAME string_28 LABELS gfortran llvm) | |||
| RUN(NAME string_29 LABELS gfortran llvm) | |||
| COMPILE(NAME string_30 COMPILERS gfortran lfortran) | |||
There was a problem hiding this comment.
This adds a complication to this cmake that we now have to maintain and ensure it actually works.
If we are just checking that llvm can be generated, why not add an llvm test or something similar?
There was a problem hiding this comment.
We are not checking LLVM generation with this test. Just -c option (which generates mod file).
certik
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2866