Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement intrinsic index #3668

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Implement intrinsic index #3668

merged 7 commits into from
Mar 19, 2024

Conversation

HarshitaKalani
Copy link
Contributor

@HarshitaKalani HarshitaKalani commented Mar 18, 2024 •
edited

Towards: #3034

@Pranavchiku
Copy link
Contributor

The CI error is unrelated, rebase this, resolve conflicts and this will be good to merge.

@Pranavchiku Pranavchiku added needs rebase Rebase on top of latest main is required/desired feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function labels Mar 18, 2024
@HarshitaKalani HarshitaKalani marked this pull request as ready for review March 19, 2024 05:37
@HarshitaKalani HarshitaKalani merged commit dafcd15 into lfortran:main Mar 19, 2024
21 checks passed
Pranavchiku
Pranavchiku reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. You may wish to look at #3671 to have an idea about implementing complex intrinsic, still not sure if that is right approach.

@HarshitaKalani
Copy link
Contributor Author

Thanks for this

@HarshitaKalani HarshitaKalani mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku left review comments

@certik certik certik approved these changes

Assignees
No one assigned
Labels
feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function needs rebase Rebase on top of latest main is required/desired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HarshitaKalani @Pranavchiku @certik