Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement intrinsic Besselj0 #3671

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

Pranavchiku
Copy link
Contributor

I am not sure if this is right way but implementing this in ASR will be really tough job to do. I guess this is a good way forward to support these type of functions.

@Pranavchiku Pranavchiku added feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function labels Mar 19, 2024
@Pranavchiku
Copy link
Contributor Author

Pranavchiku commented Mar 19, 2024

CI Failure: /home/runner/work/lfortran/lfortran/src/libasr/runtime/lfortran_intrinsics.c:1201: undefined reference to __sincos

@Pranavchiku
Copy link
Contributor Author

This works well on my device ( Mac M2 Air ), I'll check on linux device if CI fails.

@Pranavchiku Pranavchiku marked this pull request as ready for review March 21, 2024 14:12
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

@certik certik merged commit b5c1661 into lfortran:main Mar 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue or pull request for adding a new feature intrinsic Issue or pull request specific to intrinsic function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants