Sync libasr from LPython
#3713
Merged
Sync libasr from LPython
#3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
reviewed
Mar 26, 2024
Comment on lines
+550
to
+565
| static inline ASR::asr_t* create_ObjectType(Allocator& al, const Location& loc, | ||
| Vec<ASR::expr_t*>& args, diag::Diagnostics& diag) { | ||
| if (args.size() != 1) { | ||
| append_error(diag, "type() takes exactly 1 argument `object` for now", loc); | ||
| } | ||
| ASR::expr_t *m_value = nullptr; | ||
| Vec<ASR::expr_t *> arg_values; | ||
|
|
||
|
|
||
| m_value = eval_ObjectType(al, loc, expr_type(args[0]), arg_values, diag); | ||
|
|
||
|
|
||
| return ASR::make_IntrinsicElementalFunction_t(al, loc, | ||
| static_cast<int64_t>(IntrinsicElementalFunctions::ObjectType), | ||
| args.p, args.n, 0, ASRUtils::expr_type(m_value), m_value); | ||
| } |
There was a problem hiding this comment.
TODO: this can be shifted to python script. Can be done after sync, this is fine.
Pranavchiku
reviewed
Mar 26, 2024
Comment on lines
-84
to
94
| (ArrayConstant | ||
| (ArrayConstructor | ||
| [] | ||
| (Array | ||
| (Integer 4) | ||
| [((IntegerConstant 1 (Integer 4)) | ||
| (IntegerConstant 0 (Integer 4)))] | ||
| FixedSizeArray | ||
| ) | ||
| () | ||
| ColMajor | ||
| ) |
There was a problem hiding this comment.
Why is this an ArrayConstructor? It should be ArrayConstant
There was a problem hiding this comment.
Let's fix it after the sync. I am not worried too much about it. The sync is already very heavy.
Pranavchiku
reviewed
Mar 26, 2024
| @@ -168,14 +168,15 @@ | |||
| )] | |||
| [(Assignment | |||
| (Var 3 strings) | |||
| (ArrayConstant | |||
| (ArrayConstructor | |||
Pranavchiku
reviewed
Mar 26, 2024
| __libasr__created__var__0__array_constant_: | ||
| __libasr__created__var__0__array_constructor_: |
There was a problem hiding this comment.
This should be __libasr__created__var__0__array_constant_
Pranavchiku
reviewed
Mar 26, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.