Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM: Support Real and Logical types with Arrays #66

Merged
merged 10 commits into from
Jul 31, 2022
Merged

WASM: Support Real and Logical types with Arrays #66

merged 10 commits into from
Jul 31, 2022

Conversation

Shaikh-Ubaid
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid commented Jul 31, 2022 •
edited

This PR adds support for real and logical type 1D-arrays.

CC: @czgdp1807

@Shaikh-Ubaid Shaikh-Ubaid added wasm WebAssembly Backend arrays Arrays labels Jul 31, 2022
@Shaikh-Ubaid
Copy link
Member Author

Please possibly review and please share feedback.

@certik
Copy link
Contributor

certik commented Jul 31, 2022

Otherwise it looks good.

@Shaikh-Ubaid
Copy link
Member Author

Shaikh-Ubaid commented Jul 31, 2022 •
edited

The commits WASM: Support logicals of kind 4 only and WASM: Support logicals of kind 4 only in visit_Cast() could have been done in a single commit, but are explicity kept separate so that if in future we find that we need cast support for logicals, we can just revert the specific commit WASM: Support logicals of kind 4 only in visit_Cast().

certik
certik approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Shaikh-Ubaid
Copy link
Member Author

Shaikh-Ubaid commented Jul 31, 2022 •
edited

Also, the WASM Backend currently does not support character or character arrays.

There are few places which deal with or contain or is related to character type and they are (at the moment) mostly dummy and it mostly acts as a place holder for future code.

I will add support for character type soon.

@certik certik merged commit 96247fc into lfortran:main Jul 31, 2022
@Shaikh-Ubaid Shaikh-Ubaid deleted the wasm_arrays_real_and_logical branch July 31, 2022 17:47
@Shaikh-Ubaid Shaikh-Ubaid mentioned this pull request Aug 15, 2022
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
arrays Arrays wasm WebAssembly Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shaikh-Ubaid @certik