Support macOS v12 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfroms
reviewed
Sep 2, 2023
Comment on lines
-39
to
+41
| view.sizingOptions = [] | ||
| if #available(macOS 13.0, *) { | ||
| view.sizingOptions = [] | ||
| } |
There was a problem hiding this comment.
What are the implications of these changes? Any changes to behavior?
There was a problem hiding this comment.
As far as I can tell, no. I tested on the macOS 12 VM
Comment on lines
-67
to
+73
| collectionBehavior = [.auxiliary, .stationary, .moveToActiveSpace, .fullScreenAuxiliary] | ||
| if #available(macOS 13.0, *) { | ||
| collectionBehavior = [.auxiliary, .stationary, .moveToActiveSpace, .fullScreenAuxiliary] | ||
| } else { | ||
| collectionBehavior = [.stationary, .moveToActiveSpace, .fullScreenAuxiliary] | ||
| } |
There was a problem hiding this comment.
Same here, how does this affect behavior (i.e. animations) on macOS 12? Do you have a screen recording of the result?
There was a problem hiding this comment.
Yup, here ya go
ProducerToolkitMacOS12-720p.mov
lfroms
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on one of my apps using a macOS 12 VM (easy to do w/VirtualBuddy). Appears everything works, but obviously just one use case.