Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect icons when using Rez for assignment #75

Closed
rktprof opened this issue Sep 4, 2023 · 6 comments
Closed

Incorrect icons when using Rez for assignment #75

rktprof opened this issue Sep 4, 2023 · 6 comments

Comments

@rktprof
Copy link

rktprof commented Sep 4, 2023

The folder icons were updated at some point, so when creating icons for macOS Ventura the icons doesn't look right

Here is an example of a generated icon on the left and a standard icon on the right (from two Get Info windows)
Screenshot 2023-09-04 at 11 41 34

@lgarron
Copy link
Owner

lgarron commented Sep 5, 2023

Hmm, there are a couple of potential reasons you could be seeing a difference in icons. Could I ask you to upload and share the .iconset of your icon when it's not assigned to a folder, in both light and dark mode?

folderify --color-scheme light input.png && mv input.iconset light.iconset
folderify --color-scheme dark input.png && mv input.iconset dark.iconset

@rktprof
Copy link
Author

rktprof commented Sep 5, 2023

Interesting, after some more testing it seems to only happen when using direct assignment to a folder:

folderify /path/to/mask/godot.png /path/to/target/folder
folderify --output-iconset /path/to/output/godot.iconset /path/to/mask/godot.png /path/to/target/folder

gives me the incorrect icon assigned to the target folder, but the output iconset seems to be correct
godot dark.iconset.zip
godot light.iconset.zip
godot mask

I'm running macOS 13.4 Dark mode on an M1 Max Macbook Pro, installed folderify using Homebrew

@lgarron
Copy link
Owner

lgarron commented Sep 6, 2023

Okay, I suspect this is an issue with the icon assignment, possibly related to #71 (comment)

It might be worth looking at https://github.com/sveinbjornt/osxiconutils again.

I don't know when I'll have time to look into this, but I definitely want to get to the bottom of it.

@Eejit43
Copy link

Eejit43 commented Dec 2, 2023

I'm experiencing this issue as well when using the direct assignment to a folder. Any workarounds? It is a minor difference but it is bugging me a bit

@Eejit43
Copy link

Eejit43 commented Dec 2, 2023

@lgarron instead of osxiconutils, https://github.com/mklement0/fileicon seems to work like a charm! Folder looks correct when using that, aside from minor coloring and shadow differences (but that's a different issue I believe).

@Opa-
Copy link

Opa- commented Dec 13, 2023

I'm experiencing some color difference too, especially noticeable in columns mode :
image

Using folderify 3.0.13 with Ventura 13.6.3 (22G436)

Here's a zip containing the input png and the generated iconset if that helps iconset.zip

@lgarron lgarron changed the title Incorrect icons for Ventura Incorrect icons when using Rez for assignment Jan 7, 2024
@lgarron lgarron closed this as completed in 8249535 Jan 7, 2024
lgarron added a commit that referenced this issue Jan 7, 2024
Release notes:

- Fix an issue that was causing assigned icons to render incorrectly (#75).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants