Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency mocha to v5.0.2 #49

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Mar 6, 2018

This Pull Request updates dependency mocha from v5.0.1 to v5.0.2

Release Notes

v5.0.2

This release fixes a class of tests which report as false positives. Certain tests will now break, though they would have previously been reported as passing. Details below. Sorry for the inconvenience!

🐛 Fixes

  • #​3226: Do not swallow errors that are thrown asynchronously from passing tests ([@​boneskull]). Example:

    it('should actually fail, sorry!', function (done) {
      // passing assertion
      assert(true === true);
    
      // test complete & is marked as passing
      done();
    
      // ...but something evil lurks within
      setTimeout(() => {
        throw new Error('chaos!');
      }, 100);
    });

    Previously to this version, Mocha would have silently swallowed the chaos! exception, and you wouldn't know. Well, now you know. Mocha cannot recover from this gracefully, so it will exit with a nonzero code.

    Maintainers of external reporters: If a test of this class is encountered, the Runner instance will emit the end event twice; you may need to change your reporter to use runner.once('end') intead of runner.on('end').

  • #​3093: Fix stack trace reformatting problem ([@​outsideris])

:nut_and_bolt Other


Commits

v5.0.2

  • f71f347 rename wallaby.js -> .wallaby.js
  • ec8901a remove unused functionality in utils module
  • 3537061 Update to correctly licensed browser-stdout version
  • 2c720a3 do not eat exceptions thrown asynchronously from passed tests; closes #​3226
  • 5078fc5 persist paths in stack trace which have cwd as infix
  • 3792bef add opencollective header image to assets/
  • afcd08f add MAINTAINERS.md to .fossaignore [ci skip]
  • 0542c40 update README.md; closes #​3191 [ci skip]
  • 6a796cb prepare CHANGELOG for v5.0.2 [ci skip]
  • ff1bd9e update package-lock.json
  • f2ee53c Release v5.0.2

This PR has been generated by Renovate Bot.

@coveralls
Copy link

coveralls commented Mar 6, 2018

Coverage Status

Coverage remained the same at 80.0% when pulling 1c85443 on renovate/mocha-5.x into cace6b6 on master.

@renovate renovate bot merged commit 79f41e3 into master Mar 6, 2018
@renovate renovate bot deleted the renovate/mocha-5.x branch March 6, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants