-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting MS level > 1 chromatogram #246
Comments
Yes, of course. Will |
good point - as of now it supports length > 1. But I'm not sure whether that's clever. Never done anything with MS level > 1. What do you think? restrict to single level? |
I can't think of a use case with more than on level, but I don't think that's a reason to restrict it to one level. Maybe it's good to support it, as long as it's easy to get the levels back from an |
OK, so I'll have to add a slot |
- Add msLevel slot to Chromatogram class. - Add msLevel argument to chromatogram,MSnExp (issue #246). - Update documentation and add unit tests.
chromatogram,MSnExp
does not allow to extractChromatograms
for MS level > 1 yet. I didn't anticipate that this will be needed, but with SWATH data it is (see sneumann/xcms#205).The required code is ready in
.extractMultipleChromatograms
but I didn't add themsLevel
argument tochromatograms,MSnExp
(yet).@lgatto: OK if I add that and push to master?
The text was updated successfully, but these errors were encountered: