Add msLevel slot to Chromatogram class #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add msLevel slot to Chromatogram class. - Add msLevel argument to chromatogram,MSnExp (issue #246). - Update documentation and add unit tests.
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 73.57% 73.55% -0.03%
==========================================
Files 73 73
Lines 7770 7779 +9
==========================================
+ Hits 5717 5722 +5
- Misses 2053 2057 +4
Continue to review full report at Codecov.
|
|
@jotsetung - have you seen the strange error on travis-ci; any idea? |
|
No idea - but the unit tests had indeed some problems - fixed that. |
|
@lgatto, no idea why there is this one travis build failing - locally on my machine it's also running smoothly. |
|
Seems to work now, locally and on travis-ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msLevelslot toChromatogramclass.msLevelargument tochromatogram,MSnExp(issue Extracting MS level > 1 chromatogram #246).msLevel,Chromatogrammethod.See issue #246 for the initial discussion.