Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot,MSnExp,missing, type = "XIC" (issue #313) #314

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Conversation

jorainer
Copy link
Collaborator

  • Add parameter type to plot,MSnExp,missing allowing to plot all spectra (type = "spectra", default), or the XIC (type = "XIC").
  • Update related documentation.
  • Add unit tests.

- Add parameter type to plot,MSnExp,missing to allow plotting either all
  spectra, or the XIC.
- Update documentation and add unit tests.
@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #314 into master will increase coverage by 0.1%.
The diff coverage is 91.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #314     +/-   ##
=========================================
+ Coverage   75.97%   76.08%   +0.1%     
=========================================
  Files          78       79      +1     
  Lines        8350     8404     +54     
=========================================
+ Hits         6344     6394     +50     
- Misses       2006     2010      +4
Impacted Files Coverage Δ
R/functions-plotting.R 100% <100%> (ø)
R/functions-MSnExp.R 82.1% <100%> (+1.67%) ⬆️
R/methods-MSnExp.R 74.63% <50%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061c324...3bdeef9. Read the comment docs.

@lgatto lgatto merged commit f44b035 into master Feb 20, 2018
@lgatto lgatto mentioned this pull request Feb 20, 2018
@jorainer jorainer deleted the plotMsData branch February 20, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants