feat: Add Promise.all utility method. #9
Conversation
| @promise = Promise.new | ||
| @inputs = inputs | ||
| @on_fulfill = method(:on_fulfill) | ||
| @on_reject = promise.method(:reject) |
There was a problem hiding this comment.
these don't need to be instance vars, they're only used the once in chain_inputs and are never mutated
There was a problem hiding this comment.
Yup, I just did this for memoization since each call to method returns a new object.
There was a problem hiding this comment.
they can just be locals in chain_inputs though, they don't need to hang around
|
Other than the issue in |
|
I've addressed your feedback if you want to give it another look. |
| obj.instance_of?(Promise) | ||
| end | ||
|
|
||
| def count_promises(enumerable) |
There was a problem hiding this comment.
this and each_promise don't need to take a param, they can just operate on @inputs; otherwise they belong as class methods
|
One nit, and CI seems to think you've lost a line of code coverage somewhere, but otherwise LGTM |
|
The mutation test coverage seems to be flaky. The false positives seem to show up as a "Neutral failure", but I don't know how to ignore them. They also seem to be timeout errors, so I think it is from the timeout devtools uses as recommended in the mutant README. I might just disable that check on CI until I figure out how to make it more reliable. |
dylanahsmith
force-pushed
the
promise.all
branch
2 times, most recently
from
eb55fc4
to
58f429a
Compare
Based on the Promise.all javascript method. Closes lgierth#9
dylanahsmith
force-pushed
the
promise.all
branch
from
58f429a
to
0f0d696
Compare
@eapache for review
This PR adds an implementation of the Promise.all javascript method which can be useful to wait for the result of multiple promises.