Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgap 9185 gencode 1 #56

Closed
wants to merge 3 commits into from

Conversation

azat-badretdin
Copy link

The theme of this pull request - ability to run miniprot with more genetic codes, namely, in addition to "standard" ("1" in NCBI classification of gencodes), which matches in terms of stop codons and middle-of-the-sequence as popular prokaryotic code "11", the "Mold" genetic code ("4" in NCBI classification) - a lot of prokaryotic organisms use this code.

We found that using correct code "4" for these organism set produces improvements in annotation.

Thus - the nature of the request.

Thank you for your consideration!

@lh3 lh3 closed this in 4a85d52 Mar 6, 2024
@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

I have added -T to support NCBI translation table 1-5. Thanks for the PR anyway.

@azat-badretdin
Copy link
Author

I have added -T to support NCBI translation table 1-5. Thanks for the PR anyway

Thank you very much, Heng! When do you think it will be released?

@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

Just released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants