Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req] Minimize background iina window on Picture In Picture Mode #2014

Closed
fullmetalsheep opened this issue Oct 2, 2018 · 6 comments
Labels
plugin Can be implemented as a plugin type: enhancement

Comments

@fullmetalsheep
Copy link

System and IINA version:

  • macOS 10.13.4
  • IINA 0.0.15.1

Expected behavior:
Please ignore how I trigger the 'picture in picture' mode. I used bettertouchtool to setup that.
2018-10-02 19 50 22
When Entering Picture In Picture Mode, the floating player should pin to a corner, and the background iina window should minimize.

I think this should be the default behavior since we only use picture in picture mode to clear up the desktop and browse the web etc.

Actual behavior:
2018-10-02 19 49 42

When Entering Picture In Picture mode, floating player pins to a corner, but the background iina window is left in the screen.

@uiryuu
Copy link
Member

uiryuu commented Oct 2, 2018

Duplicate of #1442.

@fullmetalsheep
Copy link
Author

Duplicate of #1442.

I don't believe its a duplicate (although our terms are similar). He's requesting an option to let the player enter pip mode when minimizing iina window, while I'm requesting that after entering the pip mode, the leftover window be minimised.

@uiryuu
Copy link
Member

uiryuu commented Oct 3, 2018

Sorry, my bad. I did not read it carefully.

@lhc70000 lhc70000 added the plugin Can be implemented as a plugin label Oct 3, 2018
@rudeigerc
Copy link

Hi, is there anyone working on this issue? Could I be assigned? :)

@MuntashirAkon
Copy link
Contributor

I like the idea very much. But it looks weird as the two animations take place nearly at the same time.

@saagarjha
Copy link
Member

Fixed by #2147, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Can be implemented as a plugin type: enhancement
Projects
None yet
Development

No branches or pull requests

6 participants