Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload on create #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jfrancos
Copy link

@jfrancos jfrancos commented May 8, 2023

Adding watcher.onDidCreate where it was just watcher.onDidChange fixes The PDF does not refresh #115 for me.

I didn't look into it deeply enough to see if both were needed or if just watcher.onDidCreate was sufficient, but this works for both cases.

@jfrancos
Copy link
Author

Hey @lhl2617, anything else I can do here, to help get this merged?

@brianbentley
Copy link

Hey @lhl2617 It would be nice if we could get this merged.

@gasrodriguez
Copy link

I can confirm this is working. To test is locally, I just edited this file (on Mac) and reloaded VSCode:

~/.vscode/extensions/lhl2617.lilypond-pdf-preview-0.2.8/out/extension/pdf-preview.js

I've previously set a shortcut for go to pdf and with auto build on save looks like it will be the perfect possible workflow to me!

Please @lhl2617 do merge it whenever you can, and/or maybe consider adding someone as collaborator so they can merge pull requests (doc). Thanks everyone!

@wurzelsand
Copy link

Maybe someone should fork the project. Unfortunately, the author no longer seems to be able to take care of the project. It would be a shame if the project were to become orphaned. Especially on the Mac, I don't know of any alternative that works as smoothly as VSLilyPond.

@viktorb1
Copy link

Anyone still having issues with this? I added the onDidCreate lines into my pdf-preview.js file, restarted VSCode and it still does not auto refresh. Any ideas why that might be the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PDF does not refresh
5 participants