[Merged by Bors] - Add ‘knobby’ and ‘dots’ pipe kinds #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally
I’ll make that change once this PR is merged. |
|
I tried braille characters, but it doesn’t look very good |
|
I thought emoji arrows would be cool, but it seems that they are two code points, meaning they have to be represented as strings instead of individual characters. In a separate PR I’ll convert all the pipe kind code to use
Also, I’m not sure why my terminal isn’t rendering the emoji arrows as emoji. |
|
Proposed changes for after this PR sound good! |
lhvy
approved these changes
Mar 4, 2021
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.