Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for github rate limits (#78) #217

Merged
merged 9 commits into from
Dec 13, 2023
Merged

docs: add documentation for github rate limits (#78) #217

merged 9 commits into from
Dec 13, 2023

Conversation

jburns24
Copy link
Contributor

No description provided.

@jburns24 jburns24 requested a review from a team as a code owner November 30, 2023 16:29
@jburns24 jburns24 changed the title docs(README.md): First stab at rate limiting documentation (#78) for the githubscraper docs(README.md): First stab at rate limiting documentation (#78) Nov 30, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 30, 2023
@jburns24 jburns24 marked this pull request as draft November 30, 2023 16:31
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98787d8) 75.62% compared to head (1793d92) 75.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   75.62%   75.69%   +0.07%     
==========================================
  Files           8        8              
  Lines         644      646       +2     
==========================================
+ Hits          487      489       +2     
  Misses        117      117              
  Partials       40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrielp adrielp mentioned this pull request Dec 4, 2023
Closed
@jburns24
Addresses PR comments by;
ae13724 
 - Switching to math expression in README
 - Adding static link to the rate limit documentation
 - Adding query cost breakdown to genqlient.graphql
 - Adding current query cost to help functions
@github-actions github-actions bot added the go label Dec 7, 2023
jburns24 and others added 2 commits December 7, 2023 12:24
@jburns24 @adrielp
Apply suggestions from code review
70af8d5 
Co-authored-by: Adriel Perkins <adrielp@liatrio.com>
Signed-off-by: Joshua <joshuajohnburns@gmail.com>
@jburns24
Result of make generate adding comments to generated code
ca6bd7d
@jburns24 jburns24 marked this pull request as ready for review December 11, 2023 17:47
@jburns24 @adrielp
Apply suggestions from code review
ee3586b 
Co-authored-by: Adriel Perkins <adrielp@liatrio.com>
Signed-off-by: Joshua <joshuajohnburns@gmail.com>
@github-actions github-actions bot removed documentation Improvements or additions to documentation go labels Dec 11, 2023
@adrielp adrielp changed the title docs(README.md): First stab at rate limiting documentation (#78) docs: add documentation for github rate limits (#78) Dec 13, 2023
@adrielp adrielp merged commit 1abcb08 into main Dec 13, 2023
13 checks passed
@adrielp adrielp deleted the rate-limit-documentation branch December 13, 2023 21:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhoofard rhoofard rhoofard left review comments

@adrielp adrielp adrielp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburns24 @adrielp @rhoofard