Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: allow sslinline without client certs #1140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmon
Copy link

@bmon bmon commented Oct 16, 2023

Currently, when using sslinline=true, client certificates are always attempted to be parsed
even when not provided. This differs from the behaviour when sslinline is not used, where
client certificates are optional and will not be set if not specified.

This change allows connections to be established when sslinline is used but client certificates
are not provided.

A use-case for this would be verifying the database SSL via verify-ca and inlining sslrootcert,
while still leaving client certificates unspecified.

@evilensky
Copy link

@bmon Just ran into this very issue and came to make the same fix :) Should a unit test be created for this option? Is there anything as an outsider I could do to help get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants